Reword exception message#110481
Merged
idegtiarenko merged 6 commits intoelastic:mainfrom Jul 9, 2024
Merged
Conversation
Rewords the exception message to make it clear the documents limit is per shard, not per index.
idegtiarenko
added
>non-issue
:Distributed/Engine
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
requested changes
Jul 8, 2024
Member
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Could we just call it shard instead of index shard? I know we call it IndexShard internally but I don't think this is something users would generally understand.
# Conflicts: # server/src/internalClusterTest/java/org/elasticsearch/index/engine/MaxDocsLimitIT.java
tvernum
pushed a commit
that referenced
this pull request
Feb 25, 2025
Rewords the exception message to make it clear the documents limit is per shard, not per index.
tvernum
pushed a commit
that referenced
this pull request
Feb 25, 2025
Rewords the exception message to make it clear the documents limit is per shard, not per index.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewords the exception message to make it clear the documents limit is per shard, not per index.